Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NF: WitlessProtocol for annex ... --json commands #4228

Merged
merged 1 commit into from Mar 3, 2020

Conversation

mih
Copy link
Member

@mih mih commented Mar 2, 2020

that returns parsed JSON. No attempt is made (yet) to replace _run_annex_command_json()

--json-progress type messages are acted upon immediately (like in GitProgress), and are subsequently excluded from the normal JSON record reporting.

Split from #4206

that returns parsed JSON. No attempt is made (yet) to replace
_run_annex_command_json()

--jsob-progress type messages are acted upon immediately (like in
GitProgress), and are subsequently excluded from the normal JSON record
reporting.
@mih mih mentioned this pull request Mar 2, 2020
21 tasks
@mih
Copy link
Member Author

mih commented Mar 2, 2020

Test failure is windows open file issue.

@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

Merging #4228 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4228      +/-   ##
==========================================
- Coverage   89.23%   89.22%   -0.02%     
==========================================
  Files         275      275              
  Lines       36250    36310      +60     
==========================================
+ Hits        32348    32396      +48     
- Misses       3902     3914      +12     
Impacted Files Coverage Δ
datalad/downloaders/base.py 75.55% <0.00%> (+0.37%) ⬆️
datalad/downloaders/http.py 74.10% <0.00%> (+0.39%) ⬆️
datalad/downloaders/tests/test_http.py 61.80% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b8282b...54c70f4. Read the comment docs.

@mih mih merged commit 3ee322d into datalad:master Mar 3, 2020
@mih mih deleted the nf-annexjsonproto branch March 3, 2020 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant