Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Complain like Git if to-be-removed sibling is unknown #4257

Merged
merged 2 commits into from Mar 9, 2020
Merged

ENH: Complain like Git if to-be-removed sibling is unknown #4257

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58a063d
ENH: Complain like Git if to-be-removed sibling is unknown
adswa Mar 7, 2020
60c4788
ENH: Add a splash of color to the warning
mih Mar 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions datalad/distribution/siblings.py
View file
Open in desktop
Expand Up @@ -301,6 +301,11 @@ def __call__(
@staticmethod
def custom_result_renderer(res, **kwargs):
from datalad.ui import ui
# should we attempt to remove an unknown sibling, complain like Git does
if res['status'] == 'notneeded' and res['action'] == 'remove-sibling':
ui.message(
'Warning: No sibling "{name}" in dataset {path}'.format(**res))
return
if res['status'] != 'ok' or not res.get('action', '').endswith('-sibling') :
# logging complained about this already
return
Expand Down