Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: get_content_annexinfo: Fix init=None handling #4330

Merged
merged 1 commit into from Mar 24, 2020

Conversation

kyleam
Copy link
Contributor

@kyleam kyleam commented Mar 23, 2020

Passing init=None fails with

rec.update({'{}{}'.format(key_prefix, k): j[k]
AttributeError: 'NoneType' object has no attribute 'update'

Set rec to an empty dict when init=None.

Passing init=None fails with

    rec.update({'{}{}'.format(key_prefix, k): j[k]
    AttributeError: 'NoneType' object has no attribute 'update'

Set `rec` to an empty dict when init=None.
@codecov
Copy link

@codecov codecov bot commented Mar 23, 2020

Codecov Report

Merging #4330 into maint will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #4330      +/-   ##
==========================================
+ Coverage   89.62%   89.67%   +0.05%     
==========================================
  Files         275      275              
  Lines       36873    36894      +21     
==========================================
+ Hits        33047    33085      +38     
+ Misses       3826     3809      -17     
Impacted Files Coverage Δ
datalad/support/annexrepo.py 86.28% <100.00%> (+0.10%) ⬆️
datalad/support/tests/test_fileinfo.py 100.00% <100.00%> (ø)
datalad/downloaders/tests/test_http.py 60.96% <0.00%> (+2.16%) ⬆️
datalad/downloaders/http.py 74.90% <0.00%> (+2.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55809c6...9231276. Read the comment docs.

@yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Mar 24, 2020

Looks legit to me, thanks!

@yarikoptic yarikoptic merged commit cc7e627 into datalad:maint Mar 24, 2020
11 checks passed
@kyleam kyleam deleted the annex-contentinfo-init-none branch Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants