Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Let default result renderer tolerate non-path results #4666

Merged
merged 1 commit into from Jun 27, 2020

Conversation

mih
Copy link
Member

@mih mih commented Jun 27, 2020

Example use case: credential query
(datalad/datalad-osf#105)

There is nothing on the file system that such credentials are (or have
to be) associated with.

Before this change, the default result handler would crash on results
without a path key. After this change, it merely doesn't report a
path at all. Spacing is adjusted be

<action>(<status>): [<message>]

in this case.

Example use case: credential query
(datalad/datalad-osf#105)

There is nothing on the file system that such credentials are (or have
to be) associated with.

Before this change, the default result handler would crash on results
without a `path` key. After this change, it merely doesn't report a
path at all. Spacing is adjusted be

   `<action>(<status>): [<message>]`

in this case.
@mih
Copy link
Member Author

mih commented Jun 27, 2020

Appveyor failure is coverage submission death.

@bpoldrack
Copy link
Member

bpoldrack commented Jun 27, 2020

Thx! Was about to do the same thing for this was annoying me elsewhere, too.

@yarikoptic yarikoptic merged commit d98eb91 into datalad:maint Jun 27, 2020
9 of 10 checks passed
@mih
Copy link
Member Author

mih commented Jul 11, 2020

Thx!

@mih mih deleted the enh-nonpathresults branch Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants