ENH: Let default result renderer tolerate non-path results #4666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example use case: credential query (datalad/datalad-osf#105) There is nothing on the file system that such credentials are (or have to be) associated with. Before this change, the default result handler would crash on results without a `path` key. After this change, it merely doesn't report a path at all. Spacing is adjusted be `<action>(<status>): [<message>]` in this case.
|
Appveyor failure is coverage submission death. |
|
Thx! Was about to do the same thing for this was annoying me elsewhere, too. |
bpoldrack
approved these changes
Jun 27, 2020
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example use case: credential query
(datalad/datalad-osf#105)
There is nothing on the file system that such credentials are (or have
to be) associated with.
Before this change, the default result handler would crash on results
without a
pathkey. After this change, it merely doesn't report apath at all. Spacing is adjusted be
<action>(<status>): [<message>]in this case.