-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH(TEMP workaround): monkeypatch getpass to echo its input + RF (Credentials) #483
Conversation
…vate credential fields explicitly
yeay... works even through entire sandwich of things:
here the datalad calls annex, that one calls our archives backend, which in turn request annex back to get a file from crcns, which in turn delegates to our custom remote, and that one asks a question ;-) now need to fix that screw up I introduced for install ;) |
Current coverage is 83.06%
@@ master #483 diff @@
==========================================
Files 166 166
Lines 13593 13595 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 11288 11292 +4
+ Misses 2305 2303 -2
Partials 0 0
|
in attempt to get those missing coverages I got some RF'ing done |
* origin/master: BF: Another change in GitPYthon 2.0.5 RF: Remove .git wrangling (not needed at this point) BF: report installation path if present, else the 'ds' RF: Standardize submodule .git to be like a standalone .git NF: GitRepo.update_submodule() RF: Cleaner to test and to assume why it failed. NF: GitRepo.add_submodule()
woohoo -- +0.4% coverage and tests pass! will merge tomorrow if noone objects |
noone objected, merging! |
also mark private credential fields explicitly (before everything was considered private since only getpass could have been used so that our prompts appeared from under the annex)