Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH(TEMP workaround): monkeypatch getpass to echo its input + RF (Credentials) #483

Merged
merged 8 commits into from
Jun 2, 2016

Conversation

yarikoptic
Copy link
Member

also mark private credential fields explicitly (before everything was considered private since only getpass could have been used so that our prompts appeared from under the annex)

@yarikoptic
Copy link
Member Author

yeay... works even through entire sandwich of things:

$> datalad install Field_L_cells/gg0304_10_B/conspecific/s*          
2016-05-26 15:43:18,178 [INFO   ] Installing <Dataset path=/tmp/aa-1> (install.py:382)
You need to authenticate with 'crcns' credentials. https://crcns.org/request-account/ provides information on how to gain access
user: datalad

2016-05-26 15:43:32,977 [INFO   ] Installing <Dataset path=/tmp/aa-1> (install.py:382)
2016-05-26 15:43:33,623 [INFO   ] Installing <Dataset path=/tmp/aa-1> (install.py:382)
2016-05-26 15:43:34,267 [INFO   ] Installing <Dataset path=/tmp/aa-1> (install.py:382)

here the datalad calls annex, that one calls our archives backend, which in turn request annex back to get a file from crcns, which in turn delegates to our custom remote, and that one asks a question ;-)

now need to fix that screw up I introduced for install ;)

@codecov-io
Copy link

codecov-io commented May 27, 2016

Current coverage is 83.06%

Merging #483 into master will increase coverage by <.01%

  1. 2 files (not in diff) in datalad/distribution were modified. more
    • Misses +2
    • Hits +10
  2. 3 files (not in diff) in datalad were modified. more
    • Misses -6
    • Hits -12
@@             master       #483   diff @@
==========================================
  Files           166        166          
  Lines         13593      13595     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          11288      11292     +4   
+ Misses         2305       2303     -2   
  Partials          0          0          

Powered by Codecov. Last updated by b2cd806...0249a03

@coveralls
Copy link

coveralls commented May 27, 2016

Coverage Status

Coverage decreased (-0.005%) to 83.06% when pulling 0249a03 on yarikoptic:enh-ui-with-echo into 6d79e49 on datalad:master.

@yarikoptic
Copy link
Member Author

in attempt to get those missing coverages I got some RF'ing done

* origin/master:
  BF: Another change in GitPYthon 2.0.5
  RF: Remove .git wrangling (not needed at this point)
  BF: report installation path if present, else the 'ds'
  RF: Standardize submodule .git to be like a standalone .git
  NF: GitRepo.update_submodule()
  RF: Cleaner to test and to assume why it failed.
  NF: GitRepo.add_submodule()
@coveralls
Copy link

coveralls commented Jun 1, 2016

Coverage Status

Coverage increased (+0.2%) to 83.267% when pulling 63d420a on yarikoptic:enh-ui-with-echo into 6d79e49 on datalad:master.

@coveralls
Copy link

coveralls commented Jun 1, 2016

Coverage Status

Coverage increased (+0.3%) to 83.389% when pulling bb646ea on yarikoptic:enh-ui-with-echo into b2cd806 on datalad:master.

@coveralls
Copy link

coveralls commented Jun 1, 2016

Coverage Status

Coverage increased (+17.0%) to 100.0% when pulling c055c77 on yarikoptic:enh-ui-with-echo into b2cd806 on datalad:master.

@yarikoptic
Copy link
Member Author

woohoo -- +0.4% coverage and tests pass! will merge tomorrow if noone objects

@yarikoptic yarikoptic changed the title ENH(TEMP workaround): monkeypatch getpass to echo its input ENH(TEMP workaround): monkeypatch getpass to echo its input + RF (Credentials) Jun 1, 2016
@yarikoptic
Copy link
Member Author

noone objected, merging!

@yarikoptic yarikoptic merged commit 088b253 into datalad:master Jun 2, 2016
@yarikoptic yarikoptic deleted the enh-ui-with-echo branch June 2, 2016 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants