Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prep-travis-forssh.sh: Check SSH readiness with nc instead of sleeping #4940

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Sep 21, 2020

This change causes prep-travis-forssh.sh to wait for the SSH containers to be ready by repeatedly checking whether connections can be made to their SSH ports. This should be more robust than just sleeping for a fixed number of seconds.

@kyleam
Copy link
Contributor

kyleam commented Sep 21, 2020

Nice, thank you. I'm going to rebase this to maint.

@kyleam kyleam changed the base branch from master to maint September 21, 2020 17:57
@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #4940 into maint will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #4940      +/-   ##
==========================================
+ Coverage   89.67%   89.69%   +0.01%     
==========================================
  Files         289      289              
  Lines       40475    40475              
==========================================
+ Hits        36297    36305       +8     
+ Misses       4178     4170       -8     
Impacted Files Coverage Δ
datalad/support/gitrepo.py 90.45% <0.00%> (+0.07%) ⬆️
datalad/downloaders/base.py 78.92% <0.00%> (+0.35%) ⬆️
datalad/downloaders/http.py 84.94% <0.00%> (+0.38%) ⬆️
datalad/downloaders/tests/test_http.py 91.15% <0.00%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c88b03...a0ee206. Read the comment docs.

@kyleam kyleam merged commit ab7213e into datalad:maint Sep 21, 2020
@jwodder jwodder deleted the nc-sleep branch November 21, 2020 03:00
@yarikoptic yarikoptic added this to the 0.13.5 milestone Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants