Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: get_versioned_url - support anonymous acces (no provider) and buckets with . in name #4985

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

yarikoptic
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #4985 into maint will increase coverage by 0.04%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #4985      +/-   ##
==========================================
+ Coverage   89.86%   89.91%   +0.04%     
==========================================
  Files         292      292              
  Lines       40730    40740      +10     
==========================================
+ Hits        36604    36630      +26     
+ Misses       4126     4110      -16     
Impacted Files Coverage Δ
datalad/support/s3.py 39.62% <87.50%> (+15.10%) ⬆️
datalad/tests/test_s3.py 56.00% <100.00%> (+6.00%) ⬆️
datalad/downloaders/http.py 81.85% <0.00%> (-3.09%) ⬇️
datalad/downloaders/tests/test_http.py 88.22% <0.00%> (-2.89%) ⬇️
datalad/distribution/create_sibling.py 85.02% <0.00%> (-0.57%) ⬇️
datalad/downloaders/base.py 80.70% <0.00%> (-0.36%) ⬇️
datalad/downloaders/s3.py 41.53% <0.00%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c66363a...4484ab9. Read the comment docs.

@yarikoptic yarikoptic merged commit dcad257 into datalad:maint Oct 5, 2020
@yarikoptic
Copy link
Member Author

and thank you @kyleam for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants