BF: Don't modify PATH if not necessary #5035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PATH modification in Runner classes is meant to make sure we use bundled w/ annex git executable (except when instructed otherwise by DATALAD_USE_DEFAULT_GIT). However, don't mess with PATH when what we find to be bundled is the same thing that is found with unmodified PATH anyway. This is particularly important when the 'bundeled' location is /usr/bin and we are running in a virtual environment, leading to that PATH overruling the venv. (Closes datalad#5030)
Codecov Report
@@ Coverage Diff @@
## maint #5035 +/- ##
=======================================
Coverage 89.91% 89.91%
=======================================
Files 292 292
Lines 40742 40743 +1
=======================================
+ Hits 36635 36636 +1
Misses 4107 4107
Continue to review full report at Codecov.
|
kyleam
reviewed
Oct 14, 2020
kyleam
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PATH modification in Runner classes is meant to make sure we use
bundled w/ annex git executable (except when instructed otherwise
by DATALAD_USE_DEFAULT_GIT). However, don't mess with PATH when
what we find to be bundled is the same thing that is found with
unmodified PATH anyway. This is particularly important when the
"bundeled" location is /usr/bin and we are running in a virtual
environment, leading to that PATH overruling the venv.
Closes #5030 and by extension #5024 (when combined with #5026)