NF: command "get" #54
Conversation
|
|
||
| pathlist = '' | ||
| for path in paths: | ||
| pathlist += ' ' + path |
There was a problem hiding this comment.
and that is where I thought to raise an issue of ... files with spaces in the names. You could extend on of the test repos for testing it or just generate using @with_tree
and above loop is identical to pathlist = ' '.join(paths) but once again we might need at least to guard for spaces... and may be some other interesting characters since it is possible to ahve files with ' or " in the filenames... testcase could help to iron out working use of wrapping etc
Move pattern-handling to cmd_get.py
Make use of it in test_annexrepo.py
|
Changes Unknown when pulling 4d79e57 on bpoldrack:nf-cmd-get into * on datalad:master*. |
|
Changes Unknown when pulling 8b2cf8a on bpoldrack:nf-cmd-get into * on datalad:master*. |
|
Changes Unknown when pulling c35d0ae on bpoldrack:nf-cmd-get into * on datalad:master*. |
|
Changes Unknown when pulling fdd513a on bpoldrack:nf-cmd-get into * on datalad:master*. |
|
Changes Unknown when pulling 22ddc59 on bpoldrack:nf-cmd-get into * on datalad:master*. |
|
Changes Unknown when pulling f27ef01 on bpoldrack:nf-cmd-get into * on datalad:master*. |
Actual command is present.
Globbing is supported, anything else only if the shell itself expands it, for now.
More tests are needed, but this is a matter of creating fancy testrepos from my point of view and therefore not a topic of this PR.