Fixes for RIA when using different push/pull URLs #5608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes a problem with the version check for a newly created dataset, which would perform a local test, even if the sibling is on an SSH host.
bpoldrack
approved these changes
Apr 28, 2021
Codecov Report
@@ Coverage Diff @@
## master #5608 +/- ##
===========================================
- Coverage 90.33% 76.89% -13.45%
===========================================
Files 305 302 -3
Lines 41645 41609 -36
===========================================
- Hits 37622 31995 -5627
- Misses 4023 9614 +5591
Continue to review full report at Codecov.
|
This must be executed on the remote end, or a success is not informative.
mih
changed the title
bpoldrack
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister PR of #5607 against master
Additionally alters the behavior of the new alias feature introduced with #5592 to use a relative path for the alias. This keep the symlinks valid when moving an entire store.