RF: just pip install datalad-installer

[yarikoptic]

master branch has its own ideas and binds to some older version

$> git grep datalad.installer
.appveyor.yml:  # deploy the datalad installer, override version via DATALAD_INSTALLER_VERSION
.appveyor.yml:      python -m pip install "datalad-installer%DATALAD_INSTALLER_VERSION%"
.appveyor.yml:      python -m pip install datalad-installer
.appveyor.yml:  - sh: python -m pip install datalad-installer${DATALAD_INSTALLER_VERSION:-}

needs yet to be addressed, decided to just go with maint for now and simplify (not versioned depends etc)

[mih]

Just commenting, have no checked yet. It would be good to know if a diff to the extension setup exists, and if so why, and if all extensions need to be modified.

[mih]

It is at least missing the ability to switch the installer version without editing .appveyor.yml. The feature was introduced in the extension setup the last time the installer behavior broke, and all extensions had to be fix before any CI would work again.

install:
...
  # deploy the datalad installer, override version via DATALAD_INSTALLER_VERSION
  - cmd:
      IF DEFINED DATALAD_INSTALLER_VERSION (
      python -m pip install "datalad-installer%DATALAD_INSTALLER_VERSION%"
      ) ELSE (
      python -m pip install datalad-installer
      )
  - sh: python -m pip install datalad-installer${DATALAD_INSTALLER_VERSION:-}

it would be great if the setups converge.

[yarikoptic]

it would be great if the setups converge.

it would be great if the setup didn't diverge ;-) copied master's .appveyor with only slight tune up for maint, and then improved upon. So should be re-converging now

[codecov]

Codecov Report

Merging #5676 (57a66b7) into maint (0c6d355) will decrease coverage by 60.82%.
The diff coverage is n/a.

❗ Current head 57a66b7 differs from pull request most recent head c628af3. Consider uploading reports for the commit c628af3 to get more accurate results

@@             Coverage Diff             @@
##            maint    #5676       +/-   ##
===========================================
- Coverage   90.32%   29.49%   -60.83%     
===========================================
  Files         299      296        -3     
  Lines       42349    42313       -36     
===========================================
- Hits        38251    12480    -25771     
- Misses       4098    29833    +25735     

Impacted Files	Coverage Δ
datalad/tests/test_api.py	0.00% <0.00%> (-100.00%)	⬇️
datalad/support/digests.py	0.00% <0.00%> (-100.00%)	⬇️
datalad/tests/test_base.py	0.00% <0.00%> (-100.00%)	⬇️
datalad/tests/test_config.py	0.00% <0.00%> (-100.00%)	⬇️
datalad/ui/tests/__init__.py	0.00% <0.00%> (-100.00%)	⬇️
datalad/tests/test__main__.py	0.00% <0.00%> (-100.00%)	⬇️
datalad/tests/test_strings.py	0.00% <0.00%> (-100.00%)	⬇️
datalad/ui/tests/test_base.py	0.00% <0.00%> (-100.00%)	⬇️
datalad/support/tests/utils.py	0.00% <0.00%> (-100.00%)	⬇️
datalad/tests/test_testrepos.py	0.00% <0.00%> (-100.00%)	⬇️
... and 246 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c6d355...c628af3. Read the comment docs.

[yarikoptic]

hm, codecov offset is too big. #5688 against maint has only 0.1% . looking at diff in coverage - might relate to travis runs for high log level to not provide results, but also might relate to added INSTALL_GITANNEX: git-annex -m datalad/packages. so I will comment it out and give another full round to see if codecov report comes cleaner.

[yarikoptic]

ok, had to restart one appveyor on mac. now all green and codecov divergence is small. so we should be good to go

[mih]

Wonderful, thx @yarikoptic for the updates!