Skip to content

Conversation

@yarikoptic
Copy link
Member

Observed initially by @jwodder on
datalad/datalad-fuse#3 (comment)
since datalad-extensions-template default workflow runs on a crippled FS.

I think it makes sense to fail regardless either it is existing file or a
(broken) symlink since the idea is not to override a (possibly annexed) file

…exists

Observed initially by @jwodder on
datalad/datalad-fuse#3 (comment)
since datalad-extensions-template default workflow runs on a crippled FS.

I think it makes sense to fail regardless either it is existing file or a
(broken) symlink since the idea is not to override a (possibly annexed) file
@yarikoptic yarikoptic added this to the 0.15.1 milestone Sep 17, 2021
@yarikoptic yarikoptic added the semver-patch Increment the patch version when merged label Sep 17, 2021
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #5991 (bb7b17c) into maint (1e0f732) will decrease coverage by 2.01%.
The diff coverage is 100.00%.

❗ Current head bb7b17c differs from pull request most recent head 9144a00. Consider uploading reports for the commit 9144a00 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #5991      +/-   ##
==========================================
- Coverage   90.32%   88.31%   -2.02%     
==========================================
  Files         308      305       -3     
  Lines       42111    42098      -13     
==========================================
- Hits        38035    37177     -858     
- Misses       4076     4921     +845     
Impacted Files Coverage Δ
datalad/distributed/tests/test_ria_basics.py 97.56% <100.00%> (-0.30%) ⬇️
datalad/downloaders/base.py 78.16% <100.00%> (ø)
datalad/nonasyncrunner.py 98.96% <100.00%> (-1.04%) ⬇️
datalad/tests/test_nonasyncrunner.py 100.00% <100.00%> (ø)
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/no_annex.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/add_readme.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/check_dates.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/support/tests/utils.py 0.00% <0.00%> (-100.00%) ⬇️
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e0f732...9144a00. Read the comment docs.

@yarikoptic
Copy link
Member Author

crawler fails are likely unrelated: datalad/datalad-crawler#104 .

If no objections or other feedback -- will merge in a day or so. To make auto auto-mint release, might even merge with release label unless some other PR would "release" us sooner.

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I will leave the merge to @yarikoptic to preserve the possibility to add the release tag.

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Sep 24, 2021
@yarikoptic yarikoptic merged commit a106956 into datalad:maint Sep 24, 2021
@yarikoptic yarikoptic deleted the bf-download-url branch September 29, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Create a release when this pr is merged semver-patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants