Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Keyring.delete called uninitialized attribute #6253

Merged
merged 1 commit into from Nov 26, 2021

Conversation

bpoldrack
Copy link
Member

@bpoldrack bpoldrack commented Nov 26, 2021

Likely a typo, delete() called an uninitialized private attribute instead
of the lazy loading, protected one.

Note, that this particular bug was only recently introduced to master, so "patch" but against master.

Introduced by: 3cddd7c

Likely a typo, delete() called an unintialized private attribute instead
of the lazy loading, protected one.
@bpoldrack bpoldrack added the semver-patch Increment the patch version when merged label Nov 26, 2021
@mih
Copy link
Member

mih commented Nov 26, 2021

If you know what introduced it, please record it here.

@bpoldrack
Copy link
Member Author

If you know what introduced it, please record it here.

Updated description.

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #6253 (446cd7a) into master (a9f423a) will decrease coverage by 2.41%.
The diff coverage is 100.00%.

❗ Current head 446cd7a differs from pull request most recent head 3734042. Consider uploading reports for the commit 3734042 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6253      +/-   ##
==========================================
- Coverage   89.62%   87.21%   -2.42%     
==========================================
  Files         323      323              
  Lines       41979    41976       -3     
==========================================
- Hits        37624    36608    -1016     
- Misses       4355     5368    +1013     
Impacted Files Coverage Δ
datalad/support/keyring_.py 90.32% <100.00%> (-4.84%) ⬇️
datalad/version.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/interface/clean.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/interface/rerun.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/no_annex.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/interface/unlock.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/distribution/drop.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/add_readme.py 0.00% <0.00%> (-100.00%) ⬇️
... and 111 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9f423a...3734042. Read the comment docs.

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@mih mih merged commit 7375313 into datalad:master Nov 26, 2021
@mih mih deleted the bf-keyring-delete branch November 26, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants