Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: When download-url gets Pathobject as path convert it to a string #6317

Merged
merged 1 commit into from Jan 19, 2022

Conversation

adswa
Copy link
Member

@adswa adswa commented Dec 15, 2021

Tiny fix for #6090

@adswa adswa added the semver-patch Increment the patch version when merged label Dec 15, 2021
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #6317 (6b74c84) into master (2b92a76) will decrease coverage by 37.60%.
The diff coverage is 100.00%.

❗ Current head 6b74c84 differs from pull request most recent head 860bb4f. Consider uploading reports for the commit 860bb4f to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #6317       +/-   ##
===========================================
- Coverage   89.87%   52.27%   -37.61%     
===========================================
  Files         331      331               
  Lines       43210    43190       -20     
===========================================
- Hits        38835    22577    -16258     
- Misses       4375    20613    +16238     
Impacted Files Coverage Δ
datalad/local/download_url.py 69.79% <100.00%> (-28.13%) ⬇️
datalad/version.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/wtf.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/addurls.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/tests/test_cmd.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/interface/clean.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/interface/rerun.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/plugin/no_annex.py 0.00% <0.00%> (-100.00%) ⬇️
datalad/support/digests.py 0.00% <0.00%> (-100.00%) ⬇️
... and 229 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b92a76...860bb4f. Read the comment docs.

@adswa
Copy link
Member Author

adswa commented Jan 10, 2022

Just commenting to not let this PR become stale, but there is no urgency: This is ready for someone to look at, and a quick 4-character-change to approve or dismiss :)

@yarikoptic yarikoptic merged commit 3b2c701 into datalad:master Jan 19, 2022
yarikoptic pushed a commit that referenced this pull request Jan 19, 2022
@yarikoptic
Copy link
Member

merged, and CPed (had to manually fix path since file moved)/pushed to maint (what could go wrong, right? ;)).
Although indeed resolves the issue, IMHO it is just a band-aid for a more general issue of our code (in particular Interfaces) in many places expecting paths to be passed as string not as Path object. May be in some bright future we would get more type annotations done to catch them in CI times

jwodder pushed a commit to jwodder/datalad that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants