Skip test_system_ssh_version if no ssh found + split parsing into separate test #7422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t exist We have it only documented in the docstring and also used in few of other tests but never explicitly tested for the runner. To rely on it, I decided to add a dedicated test right there for the runner
…ing into separate test
yarikoptic
added
semver-tests
github-actions
bot
removed
the
CHANGELOG-missing
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## maint #7422 +/- ##
==========================================
+ Coverage 88.10% 90.65% +2.55%
==========================================
Files 327 327
Lines 44692 44707 +15
Branches 0 5947 +5947
==========================================
+ Hits 39374 40528 +1154
+ Misses 5318 4164 -1154
- Partials 0 15 +15
☔ View full report in Codecov by Sentry. |
jwodder
requested changes
Jun 9, 2023
| try: | ||
| WitlessRunner().run(['ssh', '-V'], protocol=StdOutErrCapture) | ||
| except FileNotFoundError as exc: | ||
| raise SkipTest(f"no ssh binary available: {exc}") |
There was a problem hiding this comment.
I think it would be preferrable to use pytest.skip() instead.
jwodder
approved these changes
Jun 9, 2023
|
PR released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some auxiliary commits as well which would have more information.
Part to address 3rd failing test on conda #7421