Skip to content

Skip test_system_ssh_version if no ssh found + split parsing into separate test - #7422

Merged
yarikoptic merged 5 commits into
datalad:maintfrom
yarikoptic:tests
Jun 9, 2023
Merged

yarikoptic merged 5 commits into
datalad:maintfrom
yarikoptic:tests

Conversation

@yarikoptic

Copy link
Copy Markdown
Member

There is some auxiliary commits as well which would have more information.

Part to address 3rd failing test on conda #7421

…t exist

We have it only documented in the docstring and also used in few of other tests
but never explicitly tested for the runner.  To rely on it, I decided to add a dedicated
test right there for the runner
@yarikoptic yarikoptic added semver-tests Changes only affect tests, no impact on version CHANGELOG-missing When a PR's description does not contain a changelog item, yet. labels Jun 8, 2023
@github-actions github-actions Bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Jun 8, 2023
@codecov

codecov Bot commented Jun 8, 2023 •

Copy link
Copy Markdown

Codecov Report

Patch coverage: 80.00% and project coverage change: +2.55 🎉

Comparison is base (560dc91) 88.10% compared to head (ce3f788) 90.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##            maint    #7422      +/-   ##
==========================================
+ Coverage   88.10%   90.65%   +2.55%     
==========================================
  Files         327      327              
  Lines       44692    44707      +15     
  Branches        0     5947    +5947     
==========================================
+ Hits        39374    40528    +1154     
+ Misses       5318     4164    -1154     
- Partials        0       15      +15     
Impacted Files Coverage Δ
datalad/support/tests/test_external_versions.py 91.35% <71.42%> (-0.91%) ⬇️
datalad/runner/tests/test_witless_runner.py 96.86% <100.00%> (+0.01%) ⬆️

... and 46 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic
yarikoptic requested a review from jwodder June 9, 2023 02:49
try:
WitlessRunner().run(['ssh', '-V'], protocol=StdOutErrCapture)
except FileNotFoundError as exc:
raise SkipTest(f"no ssh binary available: {exc}")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be preferrable to use pytest.skip() instead.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, done in ce3f788

@yarikoptic
yarikoptic requested a review from jwodder June 9, 2023 14:21
@yarikoptic
yarikoptic merged commit 7db210f into datalad:maint Jun 9, 2023
@yarikoptic-gitmate

Copy link
Copy Markdown
Collaborator

PR released in 0.18.5

@yarikoptic
yarikoptic deleted the tests branch February 13, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-tests Changes only affect tests, no impact on version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants