Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Make Dataset.id independent of annex.UUID and also for non-annex datasets #747

Merged
merged 2 commits into from
Sep 2, 2016

Conversation

mih
Copy link
Member

@mih mih commented Sep 1, 2016

all with UUIDs

hence RF get() to behave like dict.get()
@mih
Copy link
Member Author

mih commented Sep 1, 2016

Ideally, this would be merged on its own, but it is only really needed for #682 at this point, hence I'll merge it in there if necessary.

@coveralls
Copy link

coveralls commented Sep 1, 2016

Coverage Status

Coverage increased (+0.004%) to 86.776% when pulling 3b8431e on mih:rf-rethinkid into 9a6ad90 on datalad:master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 86.776% when pulling 3b8431e on mih:rf-rethinkid into 9a6ad90 on datalad:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 86.776% when pulling 3b8431e on mih:rf-rethinkid into 9a6ad90 on datalad:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 86.776% when pulling 3b8431e on mih:rf-rethinkid into 9a6ad90 on datalad:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 86.776% when pulling 3b8431e on mih:rf-rethinkid into 9a6ad90 on datalad:master.

@codecov-io
Copy link

codecov-io commented Sep 1, 2016

Current coverage is 86.77% (diff: 100%)

Merging #747 into master will increase coverage by <.01%

@@             master       #747   diff @@
==========================================
  Files           198        198          
  Lines         17887      17892     +5   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          15521      15526     +5   
  Misses         2366       2366          
  Partials          0          0          

Powered by Codecov. Last update 9a6ad90...3b8431e

@yarikoptic
Copy link
Member

@mih crazy day -- everything conflicts... otherwise I have no objections since I lost a good grasp of the ids until I will try more and see.

@mih mih merged commit 3b8431e into datalad:master Sep 2, 2016
@mih mih deleted the rf-rethinkid branch June 24, 2017 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants