RF(TST): use setup_method and teardown_method in TestAddArchiveOptions #7488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior one is coming from "nose support" layer which is about to be deprecated. So we were getting flood of warnings like local/tests/test_add_archive_content.py::TestAddArchiveOptions::test_override_existing_under_git /Users/runner/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/_pytest/fixtures.py:911: PytestRemovedIn8Warning: Support for nose tests is deprecated and will be removed in a future release. local/tests/test_add_archive_content.py::TestAddArchiveOptions::test_override_existing_under_git is using nose-specific method: `teardown(self)` To remove this warning, rename it to `teardown_method(self)` See docs: https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose next(it) for a while but didn't spot them. I think that is the only place in core.
yarikoptic
added
tests
github-actions
bot
removed
the
CHANGELOG-missing
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## maint #7488 +/- ##
=======================================
Coverage 91.52% 91.52%
=======================================
Files 325 325
Lines 43441 43441
Branches 5827 5827
=======================================
Hits 39761 39761
Misses 3665 3665
Partials 15 15
☔ View full report in Codecov by Sentry. |
|
benchmarks are generally failing, yet to be investigated. no brainer so merging |
|
PR released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior one is coming from "nose support" layer which is about to be deprecated. So we were getting flood of warnings like
local/tests/test_add_archive_content.py::TestAddArchiveOptions::test_override_existing_under_git
/Users/runner/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/_pytest/fixtures.py:911: PytestRemovedIn8Warning: Support for nose tests is deprecated and will be removed in a future release.
local/tests/test_add_archive_content.py::TestAddArchiveOptions::test_override_existing_under_git is using nose-specific method:
teardown(self)To remove this warning, rename it to
teardown_method(self)See docs: https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose
next(it)
for a while but didn't spot them. I think that is the only place in core.