Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announce test_clone_datasets_root xfail on github osx #7489

Merged
merged 2 commits into from Sep 19, 2023

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Sep 19, 2023

To make daily runs clearer to not mask some real issue.

ref:

@yarikoptic yarikoptic added semver-tests Changes only affect tests, no impact on version CHANGELOG-missing When a PR's description does not contain a changelog item, yet. labels Sep 19, 2023
@github-actions github-actions bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9942bf4) 91.52% compared to head (178a233) 91.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##            maint    #7489   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files         325      325           
  Lines       43441    43443    +2     
  Branches     5827     5827           
=======================================
+ Hits        39761    39763    +2     
  Misses       3665     3665           
  Partials       15       15           
Files Changed Coverage Δ
datalad/core/distributed/tests/test_clone.py 98.43% <100.00%> (+<0.01%) ⬆️
datalad/tests/utils_pytest.py 89.28% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member Author

yarikoptic commented Sep 19, 2023

OSX fail is unrelated actually:

FAILED ../local/tests/test_diff.py::test_path_diff - datalad.runner.exception.CommandError: CommandError: 'git -c diff.ignoreSubmodules=none -c core.quotepath=false annex find --anything --include '*' --json --json-error-messages -c annex.dotfiles=true' failed with exitcode 139 under /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/datalad_temp_test_path_difffyi0kc7_/subds_modified [info keys: stdout_json] [err: 'error: git-annex died of signal 11']

filed #7490 .

benchmarks unrelated

@yarikoptic yarikoptic merged commit ab283a1 into datalad:maint Sep 19, 2023
20 of 22 checks passed
@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.19.4

@yarikoptic yarikoptic deleted the enh-xfail branch February 2, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-tests Changes only affect tests, no impact on version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants