BF(TST): Relax matching of git-annex error message about unsafe drop, which was changed in 10.20231129-18-gfd0b510573 #7541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What matters really is that we fail and that there is "unsafe" and some message from git-annex. In [10.20231129-18-gfd0b510573](https://git.kitenet.net/index.cgi/git-annex.git/commit/?id=fd0b5105731b17899d79cade82436320ab85cb56) git-annex changed message to become better but I do not think we should overcomplicate test ot match both messages exactly since who knows what other improvements might come later again.
yarikoptic
added
tests
github-actions
bot
removed
the
CHANGELOG-missing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## maint #7541 +/- ##
==========================================
- Coverage 91.53% 91.32% -0.22%
==========================================
Files 325 325
Lines 43441 43445 +4
Branches 5827 5827
==========================================
- Hits 39765 39674 -91
- Misses 3661 3755 +94
- Partials 15 16 +1 ☔ View full report in Codecov by Sentry. |
|
travis single fail to run is unrelated, it is trivial, merging |
|
PR released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What matters really is that we fail and that there is "unsafe" and some message from git-annex. In 10.20231129-18-gfd0b510573 git-annex changed message to become better but I do not think we should overcomplicate test ot match both messages exactly since who knows what other improvements might come later again.
Marking it for release so we bring CI of git-annex builds back into green