Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: prefix with [DATALAD] if save came without msg #768

Merged
merged 1 commit into from
Sep 9, 2016

Conversation

yarikoptic
Copy link
Member

up for discussion

@mih
Copy link
Member

mih commented Sep 8, 2016

+1, but please merge this after the current PR if it leads to conflicts.

@coveralls
Copy link

coveralls commented Sep 8, 2016

Coverage Status

Coverage decreased (-2.08%) to 86.803% when pulling 3efbee1 on yarikoptic:enh-save into 014a507 on datalad:master.

@codecov-io
Copy link

codecov-io commented Sep 8, 2016

Codecov Report

Merging #768 into master will decrease coverage by 2.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #768      +/-   ##
=========================================
- Coverage   88.88%   86.8%   -2.08%     
=========================================
  Files         214     214              
  Lines       18843   18845       +2     
=========================================
- Hits        16748   16358     -390     
- Misses       2095    2487     +392
Impacted Files Coverage Δ
datalad/interface/save.py 91.89% <100%> (+0.46%) ⬆️
datalad/crawler/nodes/s3.py 32.82% <0%> (-57.26%) ⬇️
datalad/tests/test_s3.py 43.47% <0%> (-56.53%) ⬇️
datalad/downloaders/s3.py 41.73% <0%> (-51.31%) ⬇️
datalad/crawler/nodes/tests/test_s3.py 49.59% <0%> (-50.41%) ⬇️
datalad/customremotes/tests/test_datalad.py 59.25% <0%> (-40.75%) ⬇️
datalad/downloaders/tests/test_s3.py 67.92% <0%> (-28.31%) ⬇️
datalad/interface/ls.py 52.56% <0%> (-21.74%) ⬇️
datalad/support/s3.py 27.09% <0%> (-20.2%) ⬇️
datalad/downloaders/tests/test_http.py 81.74% <0%> (-14.07%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 014a507...3efbee1. Read the comment docs.

@mih mih merged commit 63ab4b7 into datalad:master Sep 9, 2016
@yarikoptic yarikoptic deleted the enh-save branch September 17, 2016 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants