DONTMERGER: Debug bk webinterface #769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datalad ls -w results in filesystem traversal at mentioned location. stores data in list with a flat sublist of files, directories per git/annex submodule. can handle recursive case too. Next: format to json for web UI consumption
reduce code in fsmodel class by inheriting from dsmodel fix bugs in list flattening date not working, parent submodule incorrect after first, symlink unicode coercion error in non datalad modules
modify DsModel for usability in FsModel after inheritance work on issue datalad#520
prints json as it computes each directory node information. not storing json in variable/memory as expect a lot of files in annex. this json is to be consumed by the web UI for the datasets. refer issue datalad#520.
Add DOC-strings to _ls_web class, follow convention Based on comments on pull#541
use dicts to allow json.dumps to handle conversion to json refactor to traverse complete directory tree only once improve node names using leaf_node function remove redundant parent repo extraction code
Each subdirectory has a json containing the metadata on files etc available in that subdirectory only, no deeper standardizes json to simplify rendering dirs for website
adds search for file at each directory level, adds css styling based on file/folder type(i.e annex, git etc) uses datatables library for rendering json as table and dir traversal
no need to unwrap each submodule before passing to fs_traverse ignored index.html, ignore root's parent for web publish
handle GET parameters in URL to specify directory to load useful for adding permalink feature remove local assets, caching should take care of asset load speed
update browser url to reflect current directory being visualized use the dir argument passed in url to find and load dir metadata json allows accessing previous location in dataset with browser back button
passing file, display, delete option explicitly prevents users from inadvertently populating their dataset with json metadata files minor bug fix in column rendering of html
automatically update dataset metadata post-update scp web interface html from local datalad repository while initialising publication target
hardcoded path to datalad virtualenv on datalad.org server, so just works for our use-case currently, fix will require post-update hook to know location of datalad on server automagically/etc
datatable sorted by node.type, datatable doesn't support custom order need sorter to create custom ordering with directories at the top
Removes '../' parent row from top dataset in html instead of datalad ls.
…rely in the future We might not bother with those relative paths until we are actually printing those models and they might all get "relpath" property if they are provided "toppath"
Add basic tests for web user interface utility functions
Fix traversal issues with the new separate metadata_dir
and GET param based traversal in root_ds.
Needed to know when current location a dataset to pick its metadata
from its metadata_dir with its hash computed using root('/') string
Wrote regression tests for fixed bugs
return window.location in loc to allow mocking all window.location make click_handler, metadata locator into function for testability test click_handler
git can't see `git submodule` from inside .git as post-update hook run from inside .git directory, doesn't see submodules hook updated to get out of .git to run metadata refresh (ls --json)
Add JS testing tools QUnit, Sinon license information to COPYING
Add test to ensure replace when existing=replace resolves datalad#732
Enable publish in test for hierarchical dataset
…ace-bisect-ssh-test-fail Conflicts: datalad/tests/utils.py - support both strip and re ok_file_has_content
Conflicts: .travis.yml -- kept both symlinked TMPDIR logic and gruntfile one
…ect-ssh-test-fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.