New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BF: added configuration to travis to test under TMPDIR with spaces, but not a symlink #772

Merged

yarikoptic merged 2 commits into datalad:master from yarikoptic:enh-symlink-travis

Sep 8, 2016

Member

yarikoptic commented Sep 8, 2016 •

edited

Loading

must fail! it did and then we fixed it

yarikoptic added 2 commits

September 8, 2016 14:50


          BK: should demonstrate the problem with spaces in tempdir which is no…

16db7a7

…t a symlink


          BF: quote tempfile name while running command specified as string

a3f7e9d

It is still not clear why "sym link" version was breaking SOME TIMES on travis
without clear consistency...

but this one should make it consistent

yarikoptic force-pushed the enh-symlink-travis branch from 47f5f24 to a3f7e9d Compare

September 8, 2016 19:03

codecov-io commented Sep 8, 2016 •

edited by codecov bot

Loading

Codecov Report

Merging #772 into master will decrease coverage by 2.08%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #772      +/-   ##
=========================================
- Coverage   88.88%   86.8%   -2.09%     
=========================================
  Files         214     214              
  Lines       18843   18843              
=========================================
- Hits        16748   16356     -392     
- Misses       2095    2487     +392

Impacted Files	Coverage Δ
datalad/tests/test_cmd.py	`95.3% <100%> (ø)`	⬆️
datalad/crawler/nodes/s3.py	`32.82% <0%> (-57.26%)`	⬇️
datalad/tests/test_s3.py	`43.47% <0%> (-56.53%)`	⬇️
datalad/downloaders/s3.py	`41.73% <0%> (-51.31%)`	⬇️
datalad/crawler/nodes/tests/test_s3.py	`49.59% <0%> (-50.41%)`	⬇️
datalad/customremotes/tests/test_datalad.py	`59.25% <0%> (-40.75%)`	⬇️
datalad/downloaders/tests/test_s3.py	`67.92% <0%> (-28.31%)`	⬇️
datalad/interface/ls.py	`52.56% <0%> (-21.74%)`	⬇️
datalad/support/s3.py	`27.09% <0%> (-20.2%)`	⬇️
datalad/downloaders/tests/test_http.py	`81.74% <0%> (-14.07%)`	⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 014a507...a3f7e9d. Read the comment docs.

coveralls commented Sep 8, 2016 •

edited

Loading

Coverage decreased (-2.08%) to 86.801% when pulling a3f7e9d on yarikoptic:enh-symlink-travis into 014a507 on datalad:master.

3 similar comments

coveralls commented Sep 8, 2016

Coverage decreased (-2.08%) to 86.801% when pulling a3f7e9d on yarikoptic:enh-symlink-travis into 014a507 on datalad:master.

coveralls commented Sep 8, 2016

Coverage decreased (-2.08%) to 86.801% when pulling a3f7e9d on yarikoptic:enh-symlink-travis into 014a507 on datalad:master.

coveralls commented Sep 8, 2016

Coverage decreased (-2.08%) to 86.801% when pulling a3f7e9d on yarikoptic:enh-symlink-travis into 014a507 on datalad:master.

coveralls commented Sep 8, 2016 •

edited

Loading

Coverage decreased (-2.08%) to 86.801% when pulling a3f7e9d on yarikoptic:enh-symlink-travis into 014a507 on datalad:master.

3 similar comments

coveralls commented Sep 8, 2016

Coverage decreased (-2.08%) to 86.801% when pulling a3f7e9d on yarikoptic:enh-symlink-travis into 014a507 on datalad:master.

coveralls commented Sep 8, 2016

Coverage decreased (-2.08%) to 86.801% when pulling a3f7e9d on yarikoptic:enh-symlink-travis into 014a507 on datalad:master.

coveralls commented Sep 8, 2016

Coverage decreased (-2.08%) to 86.801% when pulling a3f7e9d on yarikoptic:enh-symlink-travis into 014a507 on datalad:master.

yarikoptic changed the title ~~WiP BK: should demonstrate the problem with spaces in tempdir which is not a symlink~~ BF: added configuration to travis to test under TMPDIR with spaces, but not a symlink

yarikoptic merged commit 511f3be into datalad:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment