Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Webinterface #954

Merged
merged 25 commits into from
Oct 11, 2016
Merged

BF: Webinterface #954

merged 25 commits into from
Oct 11, 2016

Conversation

debanjum
Copy link
Contributor

@debanjum debanjum commented Sep 29, 2016

  • Remove parent row .. in webinterface root
  • Use parent dataset type from parent metadata to color code .. row

Closes: #917

@codecov-io
Copy link

codecov-io commented Sep 29, 2016

Codecov Report

Merging #954 into master will decrease coverage by <.01%.
The diff coverage is 93.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #954      +/-   ##
==========================================
- Coverage   89.93%   89.93%   -0.01%     
==========================================
  Files         224      224              
  Lines       21506    21524      +18     
==========================================
+ Hits        19341    19357      +16     
- Misses       2165     2167       +2
Impacted Files Coverage Δ
datalad/distribution/tests/test_target_ssh.py 98.63% <ø> (ø) ⬆️
datalad/distribution/create_sibling.py 78.94% <ø> (ø) ⬆️
datalad/consts.py 100% <100%> (ø) ⬆️
datalad/interface/tests/test_ls.py 97.01% <100%> (ø) ⬆️
datalad/interface/ls.py 73.05% <92.85%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 588f38d...aa1f645. Read the comment docs.

@yarikoptic
Copy link
Member

deployed it to datasets.datalad.org and .. actually came back at the top level! (left it hanging there for you to see). colors of '..' in subdatasets look correct though - so we should be really close to breadcrumbs navigator, right? ;)

@debanjum
Copy link
Contributor Author

just saw this still existing '..' row on the root ds. yeah breadcrumbs enh should be pushed this weekend

Crumbs not color coded by type of crumb from annex, dir, git dir type
@mih
Copy link
Member

mih commented Oct 10, 2016

Any chance for #917 to be considered in this PR?

@yarikoptic
Copy link
Member

yeah -- would be nice... I am just learning this whole js thing... might as well do if figure out how. First want to get ahold of meta-data

@yarikoptic
Copy link
Member

yarikoptic commented Oct 10, 2016

@mih Here is how it looks atm ;)
http://www.onerussian.com/tmp/gkrellShoot_10-10-16_171425.png
I might push it to "deployment" later today

edit 1: did minor change after that to point to datalad.org itself

@debanjum
Copy link
Contributor Author

debanjum commented Oct 10, 2016

All this looks really nice!

Not sure about using the strike through for not installed datasets though.

* origin/master: (76 commits)
  BF: few more to rename LOGTARGET -> LOG_TARGET, LOGNAME->LOG_NAME, ...
  BF(TST): result depends on setting of log.outputs, which now also set in one travis env
  ENH: provide getbool helper (with a default, and raising TypeError if some other value)
  ENH+RF:  drop filename:lineno from log messages in favor of LOG_TRACEBACK which now can take integer value for how many to present
  ENH: log.outputs config setting to trigger logging of the stdout/stderr (to address datalad#971)
  BF: now it is LOG_LEVEL not LOGLEVEL
  DOC: minor fixes
  report coverage before and after comining
  RF+BF: yield all hits for datasets with multiple locations + dedent test body
  somewhat giving up -- some pythons react with invalid and others with too few args
  RF: re-found tests for cmdline and moved under cmdline module. merged with just added
  ENH: guard for case if func is present but not defined
  BF: explicitly guard against no command specified (Closes datalad#978)
  RF+ENH(TST): smoke test being able to export search in json and yaml
  ENH(TST): smoke test for search on our mega-super-dataset
  ENH(TST): cover some rendering of results in search
  BF(TST): unrelated to PY3 changes -- one test was not effective
  BF(PY3): carry decoded version for comparisons
  BF(PY3): few more caught screw ups "fixed"
  BF(PY3): use the protocol 2 for cookies db for now so both py2 and py3 could use it
  ...
@yarikoptic
Copy link
Member

@debanjum well -- that is what they are -- not there. Should not in general happen on datasets.datalad.org ATM so I would just keep with a strikethrough atm. Whenever we get to the situation where it is kinda not appropriate -- we will adjust.
I will now merge master, fix the failing test, push and if/when tests pass will try to deploy.

@yarikoptic
Copy link
Member

after few BF and RF deployed to http://datasets.datalad.org . openfmri one looks neat imho although even somewhat noisy (might want to shorten all descriptions and look into providing extended one in tooltips or smth like that).

@yarikoptic
Copy link
Member

tests pass, no objections so will merge

@yarikoptic yarikoptic merged commit 810bb29 into datalad:master Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants