-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BF: Webinterface #954
BF: Webinterface #954
Conversation
remove unnecessary tests, fix metadata locator to do locate parent metadata too
refer datalad#794 for details
Codecov Report
@@ Coverage Diff @@
## master #954 +/- ##
==========================================
- Coverage 89.93% 89.93% -0.01%
==========================================
Files 224 224
Lines 21506 21524 +18
==========================================
+ Hits 19341 19357 +16
- Misses 2165 2167 +2
Continue to review full report at Codecov.
|
deployed it to datasets.datalad.org and .. actually came back at the top level! (left it hanging there for you to see). colors of '..' in subdatasets look correct though - so we should be really close to breadcrumbs navigator, right? ;) |
just saw this still existing '..' row on the root ds. yeah breadcrumbs enh should be pushed this weekend |
Crumbs not color coded by type of crumb from annex, dir, git dir type
now duplicates records of the parent ds in each node of itself, which blows size without need (probably). TODO
d704087
to
4b8e5fc
Compare
… + no need to extract twice (use copy)
Any chance for #917 to be considered in this PR? |
yeah -- would be nice... I am just learning this whole js thing... might as well do if figure out how. First want to get ahold of meta-data |
…lly not installed subds
@mih Here is how it looks atm ;) edit 1: did minor change after that to point to datalad.org itself |
All this looks really nice! Not sure about using the strike through for not installed datasets though. |
…to facilitate search of the table
* origin/master: (76 commits) BF: few more to rename LOGTARGET -> LOG_TARGET, LOGNAME->LOG_NAME, ... BF(TST): result depends on setting of log.outputs, which now also set in one travis env ENH: provide getbool helper (with a default, and raising TypeError if some other value) ENH+RF: drop filename:lineno from log messages in favor of LOG_TRACEBACK which now can take integer value for how many to present ENH: log.outputs config setting to trigger logging of the stdout/stderr (to address datalad#971) BF: now it is LOG_LEVEL not LOGLEVEL DOC: minor fixes report coverage before and after comining RF+BF: yield all hits for datasets with multiple locations + dedent test body somewhat giving up -- some pythons react with invalid and others with too few args RF: re-found tests for cmdline and moved under cmdline module. merged with just added ENH: guard for case if func is present but not defined BF: explicitly guard against no command specified (Closes datalad#978) RF+ENH(TST): smoke test being able to export search in json and yaml ENH(TST): smoke test for search on our mega-super-dataset ENH(TST): cover some rendering of results in search BF(TST): unrelated to PY3 changes -- one test was not effective BF(PY3): carry decoded version for comparisons BF(PY3): few more caught screw ups "fixed" BF(PY3): use the protocol 2 for cookies db for now so both py2 and py3 could use it ...
@debanjum well -- that is what they are -- not there. Should not in general happen on datasets.datalad.org ATM so I would just keep with a strikethrough atm. Whenever we get to the situation where it is kinda not appropriate -- we will adjust. |
…l files (subdirectories) I would need to fix up all the post-update hooks with something like find -iname post-update -print0 | xargs -0 sed -i -e 's, -r , -a ,g'
after few BF and RF deployed to http://datasets.datalad.org . openfmri one looks neat imho although even somewhat noisy (might want to shorten all descriptions and look into providing extended one in tooltips or smth like that). |
tests pass, no objections so will merge |
..
in webinterface root..
rowCloses: #917