New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up for testing git-annex on non-GitHub clients #102
Conversation
@yarikoptic Please create a datalad/git-annex-ci-client-jobs repository and give me write permission so I can set up the badges-and- Also, a GitHub token for writing to the new repository needs to be added to this repository as a secret named |
I setup that repo, but do we need one more repo? I thought we could just use branches in that singular one for badges too
you are admin in both. Please create one and share (privately)? |
I'm setting this up so that, when the script runs on a client, it pulls the latest configuration from this repository, which means it has to run in a clone of this repository. Thus, if the script also pulled |
note: the same repo could be cloned/checked out into the same/different branches in an infinite number of locations ;-) |
note: I was arguing only against (somewhat) creating
? |
@yarikoptic I did mean "repository"; git-annex-ci-client-jobs is the On further consideration (including the fact that GitHub tokens can't be scoped to a single repository), I may just use datalad/git-annex for all of the branches & badges and not bother with git-annex-ci-client-jobs. |
my only concern so far against that would be that those |
@yarikoptic So should we use a separate repository or not?
|
if it is easier to go without a separate one with no impact on other operation of datalad/git-annex workflows (e.g. would main cron job get "cloning" of the repo very much slower to start with?) -- using one for everything is ok with me. Your choice.
there is https://github.com/datalad-tester we could "recover" if needed ;-)
would be as fine if needed. |
ha -- I don't remember doing that in my clear consciousnesses ;) It is still WiP, right @jwodder ? |
@yarikoptic Yes. I've decided to use separate repositories, and I've set up a deploy key for cloning. There's a test build running right now. After that, I still need to do the items listed in the initial comment. |
@yarikoptic Do you have a preferred GPG key to use for signing the |
@yarikoptic Also, I want to set up tinuous to collect logs & artifacts from datalad/git-annex-ci-client-jobs, and I want to set it up next to the tinuous setup for the datalad/git-annex logs, but I don't remember where that is. It doesn't seem to be under dandi@drogon's account. |
We already have one in secrets of this repo -
I guess Error out would be the safest? I do understand that it might lead to the flood of CRON error notifications since then we would not "react" to present
that would be great! drogon contains only |
I meant, should it exit immediately or continue with other |
I guess we would iron out gory details after trying and seeing. I would rely on your analysis of desired logic, meanwhile
I guess "other" in the order sorted by version?
I guess without deletion we would go in an infinite loop... I feel that we eventually should introduce some way to "protocol" what was tried so we don't come back to it... may be we should push |
@yarikoptic The client setup is working now, though I'm not going to actually create a cronjob until this branch is merged, as the code auto-updates from master. The only problem is that ndoli is very, very slow, and the tests keep hitting the one-hour timeout I set. |
eh, right -- on the discovery main node under a POSIXy but in general, if PR is ready -- time to take out of draft mode? |
@yarikoptic Ready for review. |
FWIW: seeking possible ideas from @joeyh on speeding tests battery up https://git-annex.branchable.com/todo/speed_up___34__standalone_build__34___and__47__or_tests/?updated |
meanwhile, could you please setup client testing on smaug. It should not be as "exciting" as discovery, but at least would give us a sample client to test / report on |
@yarikoptic Should the smaug tests run the tests in any specific directory? |
@yarikoptic Also, what user account should I set this up under? |
probably as |
@yarikoptic Could you please merge this PR? Working with a different branch in a single-branch clone is very annoying. |
sure -- feel welcome to click Merge whenever you feel you want that state merged (I just see a fresh commit being tested). |
@yarikoptic Client set up on smaug. |
@joeyh fixed running standalone tests which might provide drastic boost! Let's see the timing on tomorrow build. |
Closes #57.
To do:
testannex.py
prune localresult-*
branches that have been deleted remotelyHandle "duplicate"build-*
branches that occur when a build workflow is attempted again after thebuild-*
branch has already been processed & deleted?