Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin command? #128

Closed
meaziz opened this issue Jun 5, 2018 · 4 comments
Closed

Plugin command? #128

meaziz opened this issue Jun 5, 2018 · 4 comments

Comments

@meaziz
Copy link

meaziz commented Jun 5, 2018

This is not an issue per say.
The problem is I'm trying to create a grid of cards where the image represents a map
I'am using the Map Generator Plugin. -> https://github.com/eddiesigner/sketch-map-generator

Following the guide the layer name should be
#plugin[true, Map Generator > Generate a Map Using Google Maps]

I thing the command path I'm using is not right but can't find a way to know it.

Any help?

@danscriptive
Copy link

+1

@nitrada
Copy link
Member

nitrada commented Jun 8, 2018

@meaziz
we never tried that combination of plugins. will have a look.

@nitrada
Copy link
Member

nitrada commented Jun 10, 2018

doesn't work here neither – it seems the "plugin" command is broken (as I also didn't manage to run any other plugin). getting this error message:

image

@lukasondrej do you have an idea?

@treshenry
Copy link

I'm not sure this would work right now anyway because I believe the map generator plugin would need to look for the location data in the layer's metadata where the data populator stashes it. Take a look at:
https://github.com/preciousforever/sketch-data-populator/blob/c5f7fa550d01b77361ceb78b4e73817c62062780/src/library/actions/plugin.js#L95-L105

Currently sketch-map-generator only receives input from the dialog it pops: https://github.com/eddiesigner/sketch-map-generator/blob/8235cc62dff894ee93d3b11333d420e9095776b5/Map%20Generator.sketchplugin/Contents/Sketch/google.js

Might be possible to modify sketch-map-generator to support a non-gui command that looks for the data this plugin stashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Data Populator for Sketch
  
Needs review/discussion
Development

No branches or pull requests

5 participants