Skip to content

Commit

Permalink
Fix rename problem
Browse files Browse the repository at this point in the history
  • Loading branch information
@ChristophLabacher
ChristophLabacher committed Dec 13, 2016
1 parent e085642 commit df20efb
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion dist/aspectRatio.sketchplugin/Contents/Sketch/manifest.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "",
"author": "CL/precious design studio",
"authorEmail": "christoph.labacher@precious-forever.com",
"version": "0.0.1",
"version": "0.0.3",
"identifier": "com.precious-forever.sketch-aspectRatio",
"menu": {
"isRoot": false,
Expand Down
8 changes: 4 additions & 4 deletions dist/aspectRatio.sketchplugin/Contents/Sketch/plugin.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,9 @@ function setAspectRatioList(context) {
keep = 'height';
}

var rename = 'true';
var rename = true;
if (renameValueIndex === 1) {
rename = 'false';
rename = false;
}

(0, _setAspectRatioForSelection.setAspectRatioForSelection)(selection, [ratio1, ratio2], keep, rename);
Expand Down Expand Up @@ -244,7 +244,7 @@ var HKSketchFusionExtension = exports.HKSketchFusionExtension = {
description: '',
author: 'CL/precious design studio',
authorEmail: 'christoph.labacher@precious-forever.com',
version: '0.0.1',
version: '0.0.3',
identifier: 'com.precious-forever.sketch-aspectRatio',
menu: {
'isRoot': false,
Expand Down Expand Up @@ -300,7 +300,7 @@ __globals.___setAspectRatioList_run_handler_ = function (context, params) {
"description": "",
"author": "CL/precious design studio",
"authorEmail": "christoph.labacher@precious-forever.com",
"version": "0.0.1",
"version": "0.0.3",
"identifier": "com.precious-forever.sketch-aspectRatio",
"menu": {
"isRoot": false,
Expand Down
2 changes: 1 addition & 1 deletion gulpfile.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ gulp.task('release', ['zip'], function() {
//tag: 'v1.0.0', // if missing, the version will be extracted from manifest and prepended by a 'v'
//name: 'publish-release v1.0.0', // if missing, it will be the same as the tag
//notes: 'very good!', // if missing it will be left undefined
draft: true, // if missing it's false
draft: false, // if missing it's false
prerelease: true, // if missing it's false
manifest: require('./build/manifest.json') // package.json from which default values will be extracted if they're missing
}));
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "sketch-ascpect-ratio",
"version": "0.0.2",
"version": "0.0.3",
"description": "",
"author": "CL/precious design studio",
"authorEmail": "christoph.labacher@precious-forever.com",
Expand Down
4 changes: 2 additions & 2 deletions src/commands/setAspectRatioList.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@ export default function setAspectRatioList (context) {
keep = 'height'
}

var rename = 'true'
var rename = true
if (renameValueIndex === 1) {
rename = 'false'
rename = false
}

setAspectRatioForSelection(selection, [ratio1, ratio2], keep, rename)
Expand Down
2 changes: 1 addition & 1 deletion src/plugin.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export const HKSketchFusionExtension = {
description: '',
author: 'CL/precious design studio',
authorEmail: 'christoph.labacher@precious-forever.com',
version: '0.0.2',
version: '0.0.3',
identifier: 'com.precious-forever.sketch-aspectRatio',
menu: {
'isRoot': false,
Expand Down

2 comments on commit df20efb

@nitrada
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChristophLabacher und bei "set manually" kommt auch noch n append?

und wenn die "set aspect ratio to" einträge nicht aus dem config JS kommen können, dann würde ich den eintrag auch einfach entfernen…

@ChristophLabacher
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitrada diesmal aber: https://github.com/preciousforever/sketch-aspect-ratio/releases/tag/v0.0.5

Ich hab die Einträge jetzt rausgemacht, Niko meinte noch dass man so per Sketch Runner auf die zugreifen kann, das heißt falls ihr das benutzt könnte ich da die häufigsten einfügen, aber eigentlich braucht man das ja nicht.

Please sign in to comment.