Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checksum calcuation #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix checksum calcuation #5

wants to merge 1 commit into from

Conversation

naomai
Copy link

@naomai naomai commented Jun 17, 2024

Thank you for creating the library. I'm using it for making warehouse labels, as it's compact, and produces razor sharp barcodes when printed on a label printer.

This PR fixes the chcksum calculation, as one of the additions was incorrectly made after the modulo operation. Instead, I propose using 104 (start code B) as an init number, which effectively shifts the result by 1.
Fixes #2 #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Barcode for "GE620034" is unreadable.
1 participant