New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in y_t output calculation #30

Open

zafarali opened this issue Apr 8, 2018 · 0 comments

Assignees

Contributor

zafarali commented Apr 8, 2018

As pointed out in https://medium.com/@charlesenglebert/hello-f890944e39fd there is an issue in calculating the y_t in our model.

keras-attention/models/custom_recurrents.py

Lines 275 to 279 in 856dbe6

    
           yt = activations.softmax( 
        
               K.dot(ytm, self.W_o) 
        
               + K.dot(stm, self.U_o) 
        
               + K.dot(context, self.C_o) 
        
               + self.b_o)

Should be st and not stm (see also eqn 4 in the Bahdanau paper)

The text was updated successfully, but these errors were encountered:

zafarali assigned zafarali and noahshpak and unassigned zafarali

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment