Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-line filters embedded within signals can't be edited directly (3.3-pre only) #463

Closed
nblumhardt opened this issue Aug 18, 2016 · 1 comment
Labels
Milestone

Comments

@nblumhardt
Copy link
Member

  1. Start with a filter in the filter box:
Environment = "ProdTest" &&
   (@Level = "Error" || @Level = "Fatal")
  1. Add it to a signal with >>
  2. Click the filter within the signal and change || to or
  3. Ok or

The changes are not saved; the in-place editing control is not multi-line capable.

@nblumhardt nblumhardt added the bug label Aug 18, 2016
@nblumhardt nblumhardt added this to the 3.3-pre milestone Aug 18, 2016
@nblumhardt
Copy link
Member Author

Turns out this was not multi-line related after all; the determination of whether the filter had been edited or not was driven off of the underlying 'normalised' representation, which doesn't change when || -> or. Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant