Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support default signals in workspaces #770

Closed
KodrAus opened this issue Dec 4, 2018 · 8 comments
Closed

Support default signals in workspaces #770

KodrAus opened this issue Dec 4, 2018 · 8 comments

Comments

@KodrAus
Copy link
Member

KodrAus commented Dec 4, 2018

When opening a workspace there might be a particular combination of signals that are sensible defaults to have selected by default when opening that workspace.

@Suchiman
Copy link

Suchiman commented Apr 12, 2019

Yes! Also when switching workspaces, this should select the default signals of that workspace, instead of bringing your current signal selection into the other workspace. I don't think having default signals per user makes sense at that point anymore as you're always working in at least one workspace.

@smudge202
Copy link

smudge202 commented Apr 29, 2019

Somewhat related request, when you have many signals there seems to be some kind of logic that determines which are shown and which need to be searched for in the sidebar. Could that logic look at "most used" or "most recently used", please? Whilst I don't know what the logic is, the few signals I use the most I always have to search for.

@nblumhardt
Copy link
Member

Hi @smudge202 - it sounds like you may need to save the current workspace once you've searched for and selected a signal. In 5.1 (IIRC) we made this automatic, so if you haven't already upgraded, after doing so it should "just work". Let me know if it sounds like I'm off-track. Thanks!

@smudge202
Copy link

Ah, I'll make sure I'm on latest and give that a try. Thanks!

@fredrik-lundin
Copy link

Any progress, or status on if/when this will be implemented?

@nblumhardt
Copy link
Member

Thanks for the nudge, @fredrik-lundin - I'll pull it into our 6.0 feature milestone and we'll take another look - we're keen to include it if we can do so without any major caveats.

@nblumhardt nblumhardt added this to the 6.0-pre milestone Dec 16, 2019
@nblumhardt nblumhardt removed this from the 2020.1-pre milestone Apr 22, 2020
@nblumhardt nblumhardt added this to the 2020.5 milestone Nov 18, 2020
@nblumhardt
Copy link
Member

Okay! We're there 👍

Workspace details have moved under Settings (shared workspaces) and user preferences (the more common case):

image

Switching into a workspace activates the default signals associated with the workspace:

default-signals

User-level/global default signals are gone; in their place, you can now choose a default workspace under user preferences:

image

Thoughts/feedback welcome; we'll have a preview out later this week, if all goes to plan.

@nblumhardt
Copy link
Member

2020.5.5137-pre is now at https://datalust.co/download/ and on Docker Hub, in case anyone's keen to try this one out :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants