Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extent fails to open after unclean shutdown #884

Closed
nblumhardt opened this issue Aug 28, 2019 · 0 comments
Closed

Extent fails to open after unclean shutdown #884

nblumhardt opened this issue Aug 28, 2019 · 0 comments
Labels
bug
Milestone

Comments

@nblumhardt
Copy link
Member

@nblumhardt nblumhardt commented Aug 28, 2019

Via: https://docs.datalust.co/discuss/5d642417456566002e5057c7

A bug in the storage engine's recovery logic can cause a start-up failure after an unclean shutdown, in some (rare) circumstances.

The error message is:

System.Exception: Flare native storage failed (InternalError), internal panic with 'assertion failed: self.remaining() >= dst.len()'

This is because the storage engine fails to recognize a write as incomplete if metadata is truncated at a specific point in the frame (an eight-byte window). The fix requires an additional length check before proceeding to copy from the read buffer.

The bug should not cause data corruption/loss, but manual recovery will be needed if this appears again before the fix is in the wild.

@nblumhardt nblumhardt added the bug label Aug 28, 2019
@nblumhardt nblumhardt added this to the 6.0-pre milestone Aug 28, 2019
@nblumhardt nblumhardt closed this Aug 28, 2019
@nblumhardt nblumhardt modified the milestones: 6.0-pre, 5.1-patch6 Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.