Correctly detect failed Apply() parsers #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #37 and makes a number of small improvements; spinning it up via the JSON example :-)...
The number one issue is that
Apply()
should never backtrack if the applied parser fails. Communicating this out to combinators that make these decisions - particularlyOr()
- need to see theApply()
parser as having consumed input. This interacts with error location reporting, which makes for some fun juggling of locations, remainders, positions etc.