DataMapper::Hook .method_added and .singleton_method_added should call super #182

Merged
merged 1 commit into from Apr 8, 2012

Conversation

Projects
None yet
2 participants
Contributor

tobias commented Feb 11, 2012

Otherwise, any other included modules that rely on those methods
won't work properly. Plus, it's the polite thing to do :)

@tobias tobias method_added and singleton_method_added should call super
Otherwise, any other included modules that rely on those methods
won't work properly.
ee86f7d

@dkubb dkubb added a commit that referenced this pull request Apr 8, 2012

@dkubb dkubb Merge pull request #182 from tobias/master
DataMapper::Hook .method_added and .singleton_method_added should call super
df06eff

@dkubb dkubb merged commit df06eff into datamapper:master Apr 8, 2012

Owner

dkubb commented Apr 8, 2012

Thanks for this pull request, merged!

BTW, in general my belief is that when we're overriding "callback" type methods like this it's a bug not to call super at some point. If you see cases where included or extended (or the methods in this PR) are not calling super please feel free to report a bug or send a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment