This repository has been archived by the owner on Apr 17, 2018. It is now read-only.
DataMapper::Hook .method_added and .singleton_method_added should call super #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, any other included modules that rely on those methods won't work properly.
dkubb
added a commit
that referenced
this pull request
Apr 8, 2012
DataMapper::Hook .method_added and .singleton_method_added should call super
|
Thanks for this pull request, merged! BTW, in general my belief is that when we're overriding "callback" type methods like this it's a bug not to call super at some point. If you see cases where |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, any other included modules that rely on those methods
won't work properly. Plus, it's the polite thing to do :)