Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chemical structure curation #37

Closed
zhu0619 opened this issue May 6, 2021 · 2 comments
Closed

Chemical structure curation #37

zhu0619 opened this issue May 6, 2021 · 2 comments
Labels
enhancement New feature or request low-priority question Further information is requested

Comments

@zhu0619
Copy link
Contributor

zhu0619 commented May 6, 2021

Found this curation pipeline from chembl very useful and worth being a default curation step.
Paper: https://www.ncbi.nlm.nih.gov/pmc/articles/PMC7458899/#CR28
Code: https://github.com/chembl/ChEMBL_Structure_Pipeline

Do you think it's worth adding or reimplement in datamol?

@hadim
Copy link
Contributor

hadim commented May 7, 2021

We already have a bunch of standardize and sanitize functions. I packaged chembl_structure_pipeline on conda forge. It seems to me the package is mostly about working on molblock while the existing datamol function only works on rdkit Mol objects.

I guess adding some wrapping functions to chembl_structure_pipeline could be useful yeah.

Do you want to check more in detail what chembl_structure_pipeline could bring?

@hadim hadim added enhancement New feature or request low-priority question Further information is requested labels May 7, 2021
@hadim
Copy link
Contributor

hadim commented Jul 14, 2021

I don't think datamol should ship a molecule curation pipeline but it should certainly ship the functions to build such a pipeline and I think most of them are already there.

If you find yourself copy/pasting functions across the platform for building such a pipeline, open a new ticket and I can add it to datamol.

@hadim hadim closed this as completed Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low-priority question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants