Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent image output #179

Merged
merged 3 commits into from
Apr 14, 2023
Merged

Consistent image output #179

merged 3 commits into from
Apr 14, 2023

Conversation

hadim
Copy link
Contributor

@hadim hadim commented Apr 14, 2023

Checklist:

  • Was this PR discussed in a issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation is a new function is added or an existing one is deleted.
  • Added a news entry.
    • copy news/TEMPLATE.rst to news/my-feature-or-branch.rst) and edit it.

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #179 (d4ffa75) into main (b978fc5) will increase coverage by 0.01%.
The diff coverage is 93.93%.

@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
+ Coverage   91.01%   91.02%   +0.01%     
==========================================
  Files          48       48              
  Lines        3785     3801      +16     
==========================================
+ Hits         3445     3460      +15     
- Misses        340      341       +1     
Flag Coverage Δ
unittests 91.02% <93.93%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datamol/viz/utils.py 87.17% <91.30%> (+4.82%) ⬆️
datamol/viz/_lasso_highlight.py 90.82% <100.00%> (+0.19%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hadim
Copy link
Contributor Author

hadim commented Apr 14, 2023

@cwognum @dessygil FYI I noticed a few mistakes we've made in the previous PR:

  • The IPython lib was imported globally while we don't want that lib to be a direct dep of datamol but an optional dep.
  • The returned image object was inconsistent with datamol.to_image and rdkit. So, I modified the logic to match it to rdkit.

Nothing to do on your side and it's mostly FYI here.

@hadim
Copy link
Contributor Author

hadim commented Apr 14, 2023

Merging here as I don't think the failing osx test is legit here. (will fix in main if needed).

@hadim hadim merged commit 2f22ded into main Apr 14, 2023
15 of 16 checks passed
@hadim hadim deleted the jupyter branch April 14, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant