-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed GatedGCN in float16. Minor cleanups. #426
Conversation
Codecov Report
@@ Coverage Diff @@
## main #426 +/- ##
==========================================
- Coverage 66.91% 66.88% -0.03%
==========================================
Files 82 82
Lines 7819 7821 +2
==========================================
- Hits 5232 5231 -1
- Misses 2587 2590 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
g["feat"] = g["feat"] | ||
e = None | ||
|
||
if "edge_feat" in get_keys(g): | ||
g["edge_feat"] = g["edge_feat"] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why this was in the code in the first place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hahaha, My guess is that, when killing DGL in favor for PyG only, we did a ctrl+F to replace all calls to g.get_node_feats("feat")
by g["feat"]
GatedGCN part looks fine to me - have you tried to train in |
I don't have access to an IPU to train with 16-true. I can only do mixed on GPU |
Changelogs
eps
parameter to theGatedGCNPyg
layer, with a default value of1e-3
since1e-6
was causing numerical issues in float16.FullGraphMultiTaskNetwork.forward
Checklist:
feature
,fix
ortest
(or ask a maintainer to do it for you).discussion related to that PR