Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unit test for finetuning from gnn #433

Merged
merged 6 commits into from
Aug 16, 2023

Conversation

WenkelF
Copy link
Collaborator

@WenkelF WenkelF commented Aug 12, 2023

@DomInvivo the new unit test covers the following additional features:

  • Finetuning from gnn (formerly only task head)
  • Keeping & modifying modules of pretrained model after finetuning module
  • Unfreezing additional pretrained depth

@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #433 (46c166b) into main (71182f4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #433   +/-   ##
=======================================
  Coverage   64.74%   64.74%           
=======================================
  Files          89       89           
  Lines        8215     8215           
=======================================
  Hits         5319     5319           
  Misses       2896     2896           
Flag Coverage Δ
unittests 64.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
ipu 49.14% <ø> (ø)

Copy link
Collaborator

@DomInvivo DomInvivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great testing!

How long does it take to run the test?

@WenkelF
Copy link
Collaborator Author

WenkelF commented Aug 15, 2023

It runs about 2 minutes

@WenkelF
Copy link
Collaborator Author

WenkelF commented Aug 15, 2023

@DomInvivo I reduced the runtime of the test to 61 seconds by reducing the number of epochs of finetuning from 3 to 2 5ef06f2

@WenkelF
Copy link
Collaborator Author

WenkelF commented Aug 15, 2023

@DomInvivo it now runs in <10 seconds after setting sample_size=100

@DomInvivo DomInvivo merged commit 6c0787c into datamol-io:main Aug 16, 2023
5 checks passed
@DomInvivo DomInvivo linked an issue Aug 23, 2023 that may be closed by this pull request
@DomInvivo DomInvivo linked an issue Aug 29, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-level fine-tuning and "fingerprinting" Add click options for command line
2 participants