Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isinstance check and broadened tests to include more Python versions #442

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

cwognum
Copy link
Collaborator

@cwognum cwognum commented Aug 22, 2023

Changelogs

  • Fixes error with graphium-train finetuning #439 by changing an isinstance check that uses Python syntax that was not supported before Python 3.10.
  • Expanded the tests to also run on Python 3.8 and 3.9, so that we catch issues like these fast and early next time.

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation is a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

@cwognum cwognum added the fix PR that fixes an issue label Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #442 (7a6a722) into main (4adaaf7) will decrease coverage by 0.04%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
- Coverage   65.56%   65.52%   -0.04%     
==========================================
  Files          90       90              
  Lines        8226     8218       -8     
==========================================
- Hits         5393     5385       -8     
  Misses       2833     2833              
Flag Coverage Δ
unittests 65.52% <66.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
ipu 49.14% <ø> (ø)

@cwognum cwognum merged commit f96c1b6 into main Aug 22, 2023
7 checks passed
@cwognum cwognum deleted the fix-typing-py38 branch August 22, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix PR that fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error with graphium-train finetuning
2 participants