Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved logging #463

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Improved logging #463

merged 4 commits into from
Sep 18, 2023

Conversation

DomInvivo
Copy link
Collaborator

@DomInvivo DomInvivo commented Sep 11, 2023

Changelogs

  • Removed the custom GPU, LR, n_epochs logging in favor of lightning's own version

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation is a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

discussion related to that PR

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #463 (ef5db7f) into main (41a1172) will decrease coverage by 0.02%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
- Coverage   71.84%   71.83%   -0.02%     
==========================================
  Files          93       93              
  Lines        8436     8433       -3     
==========================================
- Hits         6061     6058       -3     
  Misses       2375     2375              
Flag Coverage Δ
unittests 71.83% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
ipu 49.14% <ø> (ø)

@DomInvivo DomInvivo requested review from maciej-sypetkowski and WenkelF and removed request for WenkelF September 18, 2023 15:18
@WenkelF
Copy link
Collaborator

WenkelF commented Sep 18, 2023

@DomInvivo looks fine to me

@DomInvivo DomInvivo merged commit f4f47af into main Sep 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants