Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wildcart (*) uses in SMILES #33

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix wildcart (*) uses in SMILES #33

wants to merge 2 commits into from

Conversation

FNTwin
Copy link

@FNTwin FNTwin commented Feb 20, 2024 •
edited

Changelogs

  • Fixes for wildcard(*) from input smiles

Changelogs and explanation: see #32

Checklist:

  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Write concise and explanatory changelogs below.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

@FNTwin FNTwin added the fix Fix a bug label Feb 20, 2024
@maclandrol
Copy link
Member

I think this potentially introduce some other bugs, can you check the test ?

@FNTwin
Copy link
Author

FNTwin commented Feb 20, 2024

I think this potentially introduce some other bugs, can you check the test ?

I'll do some checks and request your review once I'm done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maclandrol maclandrol Awaiting requested review from maclandrol maclandrol is a code owner

Assignees
No one assigned
Labels
fix Fix a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FNTwin @maclandrol