Request: Windows Support #19
Comments
dataphract
pushed a commit
that referenced
this issue
Jul 9, 2022
As highlighted in #19, this crate does not support Windows platforms properly yet. There is a conditional dependency on the `windows` crate declared on the Cargo.toml manifest for Windows platforms, but that dependency is unused by the source code, so it's unnecessary. Normally, this unused dependency would only make Cargo download more crates than really needed when building, but otherwise be unnoticed by most people. However, the version of the `windows` crate declared as a dependency, 0.29.0, is affected by the RUSTSEC-2022-0008 advisory, which makes automated analysis tools such as GitHub security vulnerability scanning complain. Link to the relevant security advisory: https://rustsec.org/advisories/RUSTSEC-2022-0008.html Address the situation by commenting out the troublesome dependency on the Cargo.toml file. In the future, it can be uncommented by anyone interested in implementing Windows support. I have tested the change by running `cargo test` on a Linux box.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello, I discovered your crate as dependency of dynamorio-rs / drstd which are rust safe bindings over dynamorio-sys. DynamoRIO is a cross platform binary instrumentation platform for Windows and Linux for debugging and tracing software. I see some cfg variables in your toml referring to Windows but the use of iovec is causing build failures. Did I miss something or is Windows support still WIP? I would be a happy customer if it worked on Windows. Thanks!
The text was updated successfully, but these errors were encountered: