Drop unused and vulnerable dependency on the windows crate
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As highlighted in #19, this crate does not support Windows platforms properly yet. There is a conditional dependency on the `windows` crate declared on the Cargo.toml manifest for Windows platforms, but as far as I can see that dependency is unused by the source code, so it's unnecessary. Normally, this unused dependency would only make Cargo download more crates than really needed when building, but otherwise be unnoticed by most people. However, the version of the `windows` crate declared as a dependency, 0.29.0, is affected by the RUSTSEC-2022-0008 advisory, which makes automated analysis tools such as GitHub security vulnerability scanning complain. Link to the relevant security advisory: https://rustsec.org/advisories/RUSTSEC-2022-0008.html Address the situation by commenting out the troublesome dependency on the Cargo.toml file. In the future, it can be uncommented by anyone interested in implementing Windows support. I have tested the change by running `cargo test` on a Linux box.
dataphract
approved these changes
Jul 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As highlighted in #19, this crate does not support Windows platforms properly yet. There is a conditional dependency on the
windowscrate declared on the Cargo.toml manifest for Windows platforms, but as far as I can see that dependency is unused by the source code, so it's unnecessary.Normally, this unused dependency would only make Cargo download more crates than really needed when building, but otherwise be unnoticed by most people. However, the version of the
windowscrate declared as a dependency, 0.29.0, is affected by the RUSTSEC-2022-0008 advisory, which makes automated analysis tools such as GitHub security vulnerability scanning complain:Link to the relevant security advisory: https://rustsec.org/advisories/RUSTSEC-2022-0008.html
Address the situation by commenting out the troublesome dependency on the Cargo.toml file. In the future, it can be uncommented by anyone interested in implementing Windows support. I have tested the change by running
cargo teston a Linux box.