Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mission350: Solution mistake? #63

Closed
mdrobovtseva opened this issue Jan 26, 2019 · 1 comment
Closed

Mission350: Solution mistake? #63

mdrobovtseva opened this issue Jan 26, 2019 · 1 comment

Comments

@mdrobovtseva
Copy link

mdrobovtseva commented Jan 26, 2019

While defining under_100_m = [], the aim is to keep only communication applications with less than 100m installs. However, the code in the solution keeps all applications with less than 100m installs. Below is a suggestion on how the code might look like:

under_100_m = []

for app in android_final:
    n_installs = app[5]
    n_installs = n_installs.replace(',', '')
    n_installs = n_installs.replace('+', '')
    if float(n_installs) < 100000000 and (app[1] == 'COMMUNICATION'):
        under_100_m.append(float(n_installs))
        
sum(under_100_m) / len(under_100_m)
mircealex added a commit that referenced this issue Feb 19, 2019
M350 -- bug fixing

Also solves issue #63
@mircealex
Copy link
Contributor

@mdrobovtseva thanks for reporting, we fixed this bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants