feat: sync base #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `MTableEditField`, some `material-ui` input components were being passed `inputProps`, which are for passing attributes to the rendered `input` element, inside `InputProps`, which are for passing props to the wrapped `material-ui` `Input` component. This resulted in the `aria-label` for these components (which was all that was being passed in `inputProps`) being incorrectly applied, throwing a development error and failing to render the `aria-label` in the DOM.
Fix `inputProps` incorrectly nested under `InputProps`
This PR fixes an infinity loop generated by the while loop, where the index is increased each turn and will always be above -1. This happens if the table is mounted repeatably in fast succession.
Fixes infinity loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Relate the Github issue with this PR using
#Description
Simple words to describe the overall goals of the pull request's commits.
Related PRs
List related PRs against other branches:
Impacted Areas in Application
List general components of the application that this PR will affect:
*
Additional Notes
This is optional, feel free to follow your hearth and write here :)