-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to save npz files on s3 #15
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 82.31% 82.73% +0.42%
==========================================
Files 6 6
Lines 656 672 +16
==========================================
+ Hits 540 556 +16
Misses 116 116
Continue to review full report at Codecov.
|
@@ -19,6 +22,27 @@ | |||
traildb = False | |||
|
|||
|
|||
@contextmanager | |||
def mock_s3_fs(bucket, data=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kayibal Could you please add a docstring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michcio1234 added :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try it out with large files on real S3?
@Talmaj no I didn't but I don't see why this should be different from the tests? |
S3 has sometimes problems with very large files, then they suggest using multi-part upload.
… Am 20.07.2017 um 18:48 schrieb kayibal ***@***.***>:
@Talmaj no I didn't but I don't see why this should be different from the tests?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
ea1595e
to
f057565
Compare
No description provided.