-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One-hot encode multiple columns #16
Conversation
`one_hot_encode` signature significantly changed!
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
========================================
+ Coverage 81.7% 81.9% +0.2%
========================================
Files 6 6
Lines 623 652 +29
========================================
+ Hits 509 534 +25
- Misses 114 118 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Can we make this changes backwards compatible? I know it wont't be that nice but it will save us trouble if we keep things backwards compatible...
so that backward compatibility is cleaner.
2c5eb90
to
0162805
Compare
0162805
to
9d5d7a1
Compare
When one-hot-encoding columns that contain same categories, resulting columns must have different names. This feature automatically adds original column name to resulting column name. (See docstrings.)
@kayibal Please check once again and merge if it's ok. |
No description provided.