Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One-hot encode multiple columns #16

Merged
merged 9 commits into from
Jul 21, 2017
Merged

Conversation

michcio1234
Copy link

No description provided.

@michcio1234 michcio1234 requested a review from kayibal July 19, 2017 15:35
@codecov
Copy link

codecov bot commented Jul 19, 2017

Codecov Report

Merging #16 into master will increase coverage by 0.2%.
The diff coverage is 87.5%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #16     +/-   ##
========================================
+ Coverage    81.7%   81.9%   +0.2%     
========================================
  Files           6       6             
  Lines         623     652     +29     
========================================
+ Hits          509     534     +25     
- Misses        114     118      +4
Impacted Files Coverage Δ
sparsity/sparse_frame.py 84.63% <85.71%> (-0.13%) ⬇️
sparsity/dask/reshape.py 94.73% <91.66%> (-5.27%) ⬇️
sparsity/dask/core.py 89.31% <0%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5234740...e5f33fe. Read the comment docs.

Copy link

@kayibal kayibal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Can we make this changes backwards compatible? I know it wont't be that nice but it will save us trouble if we keep things backwards compatible...

When one-hot-encoding columns that contain same categories, resulting
 columns must have different names. This feature automatically adds
 original column name to resulting column name. (See docstrings.)
@michcio1234
Copy link
Author

@kayibal Please check once again and merge if it's ok.

@kayibal kayibal merged commit 4acf016 into master Jul 21, 2017
@michcio1234 michcio1234 deleted the feature/one-hot-more-columns branch July 21, 2017 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants