-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/binning #69
Refactor/binning #69
Conversation
# Conflicts: # sparsity/test/test_dask_sparse_frame.py
implements distributed rename method and adds quicker routines to groupby_sum if divisions are known. Adds support for joining sp.SparseFrames onto a distributed SparseFrame.
# Conflicts: # sparsity/dask/core.py
# Conflicts: # sparsity/dask/core.py # sparsity/dask/shuffle.py # sparsity/sparse_frame.py # sparsity/test/test_dask_sparse_frame.py
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
=========================================
- Coverage 89.65% 89.5% -0.16%
=========================================
Files 7 7
Lines 1179 1200 +21
=========================================
+ Hits 1057 1074 +17
- Misses 122 126 +4
Continue to review full report at Codecov.
|
@@ -705,12 +705,10 @@ def test_repr(): | |||
assert isinstance(res, str) | |||
assert '10x10000' in res | |||
assert '0 stored' in res | |||
assert len(res.splitlines()) == 1 + 5 + 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did the lines number change? I can't see any change that you made that should affect it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's related to pandas version...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I hope our __repr__
still makes sense then...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should just lines change I think depending on your terminal size? Don't know...
# Conflicts: # sparsity/dask/core.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question.
@@ -6,6 +6,7 @@ jobs: | |||
- image: drtools/dask:latest | |||
steps: | |||
- checkout | |||
- run: pip install pytest pytest-cov moto dask==0.19.2 . | |||
- run: pip install boto3==1.7.84 botocore==1.10.84 moto==1.3.6 | |||
- run: pip install pytest pytest-cov dask==1.0.0 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be consistent with setup.py? Or shouldn't it be done by pip install .[test]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx it is resolved
Changes necessary to make distributed binning algorithm work