WIP: sparse dataset #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayibal
reviewed
Jul 31, 2019
sparsity/sparse_frame.py
Outdated
| ) | ||
| if prefixes: | ||
| cols = list(map(lambda x: '{}_{}'.format(column, x), cols)) | ||
| if column_cat is False: |
There was a problem hiding this comment.
Hm @michcio1234 do you think we should add a check if the column is numerical here?
Codecov Report
@@ Coverage Diff @@
## ohe-include-untouched #84 +/- ##
=========================================================
+ Coverage 89.79% 90.07% +0.28%
=========================================================
Files 7 7
Lines 1215 1290 +75
=========================================================
+ Hits 1091 1162 +71
- Misses 124 128 +4
Continue to review full report at Codecov.
|
And change sf_arange fixture to have values from 1 to 10 rather than from 0 to 9, because 0 is treated as missing in sparse frames.
When the same dsf is computed twice, results may be different
If an argument is a generator, we will call next() on it before passing it to a function for each partition.
michcio1234
changed the title
Previously, if sf was all-zero but not empty (shape was > 0), empty sf was returned anyway.
|
Superseded by 4 smaller PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.