-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sample #87
Feature/sample #87
Conversation
And change sf_arange fixture to have values from 1 to 10 rather than from 0 to 9, because 0 is treated as missing in sparse frames.
When the same dsf is computed twice, results may be different
If an argument is a generator, we will call next() on it before passing it to a function for each partition.
Previously, if sf was all-zero but not empty (shape was > 0), empty sf was returned anyway.
Starting from 1.16, it is possible to do `np.random.choice([], size=0)`. We require numpy above 1.16.0, because 1.16.0 had memory leaks. Tested with 1.16.4.
@michcio1234 Should we keep it this way? With the generator like map_partitions? If you're ok with keeping it feel free to merge! |
Yeah, I know it's a kind of magic, but it may turn out to be useful. I don't think it's dangerous. Let's leave it. |
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=========================================
+ Coverage 89.64% 89.9% +0.25%
=========================================
Files 7 7
Lines 1227 1268 +41
=========================================
+ Hits 1100 1140 +40
- Misses 127 128 +1
Continue to review full report at Codecov.
|
# Conflicts: # sparsity/test/test_sparse_frame.py
No description provided.