Feature/sample #87
Merged
Feature/sample #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And change sf_arange fixture to have values from 1 to 10 rather than from 0 to 9, because 0 is treated as missing in sparse frames.
When the same dsf is computed twice, results may be different
If an argument is a generator, we will call next() on it before passing it to a function for each partition.
Previously, if sf was all-zero but not empty (shape was > 0), empty sf was returned anyway.
Starting from 1.16, it is possible to do `np.random.choice([], size=0)`. We require numpy above 1.16.0, because 1.16.0 had memory leaks. Tested with 1.16.4.
|
@michcio1234 Should we keep it this way? With the generator like map_partitions? If you're ok with keeping it feel free to merge! |
kayibal
approved these changes
Aug 7, 2019
|
Yeah, I know it's a kind of magic, but it may turn out to be useful. I don't think it's dangerous. Let's leave it. |
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=========================================
+ Coverage 89.64% 89.9% +0.25%
=========================================
Files 7 7
Lines 1227 1268 +41
=========================================
+ Hits 1100 1140 +40
- Misses 127 128 +1
Continue to review full report at Codecov.
|
# Conflicts: # sparsity/test/test_sparse_frame.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.