Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add py37 support #22

Merged
merged 10 commits into from
Feb 3, 2022
Merged

Feature/add py37 support #22

merged 10 commits into from
Feb 3, 2022

Conversation

murilo-cunha
Copy link
Member

@murilo-cunha murilo-cunha commented Jan 20, 2022

As per suggested in #20, add python 3.7 support! 🎉

  • Change strategy for version bumping (don't use importlib.metadata)
  • Add typing-extensions to use Protocol and runtime_checkable
  • Change CI to bump version, add 3.7 in testing matrix, etc.

@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #22 (8379da7) into main (cd6ebbf) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   95.70%   95.70%   -0.01%     
==========================================
  Files          18       19       +1     
  Lines         769      768       -1     
==========================================
- Hits          736      735       -1     
  Misses         33       33              
Impacted Files Coverage Δ
databooks/cli.py 93.05% <100.00%> (-0.28%) ⬇️
databooks/data_models/base.py 88.13% <100.00%> (+0.20%) ⬆️
databooks/version.py 100.00% <100.00%> (ø)
tests/test_cli.py 100.00% <100.00%> (ø)
tests/test_data_models/test_notebook.py 100.00% <100.00%> (ø)

Copy link

@devdnhee devdnhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

installed your feature branch on my poetry env accepting 3.7 and no dependency issues, and did a few databooks commands, worked like a charm!

@murilo-cunha murilo-cunha merged commit 9f58381 into main Feb 3, 2022
@murilo-cunha murilo-cunha deleted the feature/add-py37-support branch February 3, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants