-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add py37 support #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murilo-cunha
force-pushed
the
feature/add-py37-support
branch
from
January 22, 2022 04:51
db6d844
to
237e53d
Compare
Codecov Report
@@ Coverage Diff @@
## main #22 +/- ##
==========================================
- Coverage 95.70% 95.70% -0.01%
==========================================
Files 18 19 +1
Lines 769 768 -1
==========================================
- Hits 736 735 -1
Misses 33 33
|
…untime_checkable`
…ersion dynamically from `version.py` - will be overwritten in CI
…s will not have it (overwritten in CI)
…mum coverage threshold for entire project and ignore patch coverage
murilo-cunha
force-pushed
the
feature/add-py37-support
branch
from
January 31, 2022 21:33
fbdbc5f
to
8379da7
Compare
devdnhee
reviewed
Feb 1, 2022
devdnhee
approved these changes
Feb 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
installed your feature branch on my poetry env accepting 3.7 and no dependency issues, and did a few databooks commands, worked like a charm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per suggested in #20, add python 3.7 support! 🎉
importlib.metadata
)typing-extensions
to useProtocol
andruntime_checkable